Web lists-archives.com

Re: Dolphin bug, help needed

On martedì 15 maggio 2018 04:09:10 CEST, Ongun Kanat wrote:


I'm trying to fix a bug in Dolphin. It basically doesn't show any information in columns like Artist, Image size etc. in details view.

Image size works for me, as do other roles. Album indeed looks broken.

After finding what is missing I wanted to see an example way to retrieve that metadata. I decided to look at the code of Information Panel which works correctly. After seeking some help in the IRC channel I decided to dive into the code. Information Panel uses Baloo widgets to fill that information. KFileMetada is meant to be used as a fallback compile time option. And I was told thay KFileMetadata has been deprecated.

You probably meant KFileMetaDataWidget? Yes, that's deprecated.
Without baloo (and baloo-widgets) metadata extraction doesn't work in dolphin.

However, I found that Baloo widgets still uses it somehow. Also the code in Baloo Widgets seems a bit convoluted and repeats the same checks such as multiple/single file again and again. I made some notes since the process has many layers and easy to forget. https://gist.github.com/ongun-kanat/4fc3fe331196238c74152ab42057faa7

I want the fix Dolphin bug so I need some guidance. Is it valid to use KFileMetaData directly to fill in the columns in Details View? If it's not, are there any other plans which I may help?

No, we should find the actual bug and fix it. I'd start looking what's going on in kfileitemmodel.cpp.

I also wonder if there is anyone actively working on Baloo widgets. It seems it needs some refactoring and I may need some mentoring to decide on the architecture.

Feel free to open a task in the dolphin workboard on phabricator: https://phabricator.kde.org/project/board/194/

Thanks for help,