Web lists-archives.com

Re: Changes to Phabricator review subscriptions




On Fri, May 11, 2018 at 8:25 PM, Dmitry Kazakov <dimula73@xxxxxxxxx> wrote:
> Hi, Ben!

Hi Dmitry,

>
> There is a small problem with not-subscribing Differential Revisions to
> projects: one cannot use Phabricator's Dashboard functionality for filtering
> the incoming revisions. Is there any way to configure dashboard's Revisions
> panel to all diffs related to a specific repository?
>
> Here is my default dashboard:
> https://phabricator.kde.org/home/menu/view/289/

You'll want to configure a search something like this -
https://phabricator.kde.org/differential/query/Q9pbWWtsYuN./#R

Please note that as Krita did not have any Herald rules previously,
this isn't something which has changed for you - it's always been this
way.

>
> In the central part it shows revisions for all the projects I'm a member of.
> If some person creates a diff against Krita repository, but doesn't add
> #krita project to it, I will **not** see this diff in the list. Is there
> some workaround to it?

The view you're showing there is a bucketed one, meaning it only cares
about the reviews for which you are a reviewer, or the submitter, of
the review.
The solution to this (and likely other projects which have a small
group of core developers who do the reviews) is probably to have
Herald add the responsible developers  as reviewers.

Subscribing whole projects didn't have this effect - it just sent
everyone in the project a notification about it.

>
> In the attachment you can find a screenshot of the panel when I'm logged in.
>
> --
> Dmitry Kazakov
>

Regards,
Ben