Web lists-archives.com

Re: Changes to Phabricator review subscriptions




Thanks for the responses, Ben.

I'm a bit concerned that all of this raises the barrier to entry for new contributors. Now they'll have to match up Phabricator projects with mailing lists, which do not have a 1:1 mapping. How is someone interested in Dolphin supposed to know that they need to subscribe to the kfm-dev mailing list to follow the development? It doesn't have the word "Dolphin" in it or even have a description set on https://mail.kde.org/mailman/listinfo. And Dolphin's own Phabricator page doesn't mention anything about it.

I appreciate the desire to cut down on duplicates and email overload (truly!) but are we sure this is the right approach? If we want to continue with this, I'd like to see some work put into updating our documentation on https://community.kde.org/Get_Involved/development#Communicating_with_the_team and https://community.kde.org/Infrastructure/Phabricator and for individual Phabricator project pages.

Also, was this discussed somewhere before the change was rolled out? I didn't see anything about it on kde-devel.

Nate



---- On Wed, 09 May 2018 12:21:57 -0700 Ben Cooksley<bcooksley@xxxxxxx> wrote ---- 
 > On Thu, 10 May 2018, 02:08 Nate Graham, <nate@xxxxxxx> wrote:
 > 
 > 1. What is the canonical way to be notified of Phabricator changes for 
 >  projects you're interested in? Subscribe to that project's mailing list? 
 >  Can you clarify what this means for someone who joins or "watches" a 
 >  project in Phabricator? Should we stop doing that?
 > 
 > 
 > 
 > 
 > I would recommend subscribing to the individual Projects mailing lists yes.
 > 
 > 
 > Joining or watching a Project would still result in email and notifications where the Project is a reviewer. Tasks are unaffected by this.
 > 
 > 
 >  
 >  2. If someone is subscribed to the project's mailing list and also joins 
 >  the project in Phabricator, will they continue to receive duplicate emails?
 > 
 > 
 > 
 > 
 > They shouldn't receive duplicates anymore. 
 > 
 > 
 > The only exception where duplicates would be received is if the user is individually subscribed to tasks or reviews.
 > 
 > 
 >  
 >  3. Who should be listed as reviewers for diffs? Only individual people? 
 >  Nobody?
 > 
 > 
 > 
 > 
 > Individuals. For smaller Projects it may still be practical for the Project to be the reviewer, however this does not scale for larger ones such as Frameworks and Plasma (where the complaints came from)
 > 
 > 
 >  
 >  4. What does this mean for projects like Dolphin or Spectacle that don't 
 >  have mailing lists?
 > 
 > 
 > 
 > 
 > Dolphin appears to be using the kfm-devel mailing list.
 > 
 > 
 > Projects that don't have mailing lists (and which are small by nature) will continue to have the Project subscribed for reviews.
 > 
 > 
 > 
 > 
 >  
 >  Nate
 > 
 > 
 > 
 > 
 > Cheers,
 > Ben
 > 
 > 
 >  
 >  
 >  On 05/09/2018 02:08 AM, Ben Cooksley wrote:
 >  > Hi all,
 >  > 
 >  > To improve the user experience around email and in-application
 >  > notifications from Phabricator, sysadmin have made some changes to the
 >  > configuration of our Herald rules.
 >  > 
 >  > Going forward, instead of subscribing projects to reviews, we will
 >  > only be subscribing mailing lists now. For those reviews which have
 >  > already been created, they will be updated to reflect the new practice
 >  > the next time they are changed.
 >  > 
 >  > This means that individual project members will no longer receive
 >  > notifications and emails for every single review or task change that
 >  > affects their project. Instead, they will only receive notifications
 >  > and emails for reviews they have been individually subscribed to.
 >  > 
 >  > To help this change take full effect, it would be appreciated if
 >  > people refrain from adding Projects as reviewers, as that will have
 >  > the effect of subscribing the Project to the review as well
 >  > (Phabricator does not require you specify a reviewer)
 >  > 
 >  > Should anyone have any questions regarding this, please open a thread
 >  > on the kde-devel@xxxxxxx mailing list.
 >  > 
 >  > Regards,
 >  > Ben Cooksley
 >  > KDE Sysadmin
 >  > 
 >  
 >  
 > 
 > 
 >  
 >