Web lists-archives.com

Re: Dependent review requests




Hey,


I asked the same in private before and got this answer from Renato. But I 
haven't used it till now...

> I saw that you have managed it to get something like "stack" inside a 
> Review Request. Like in https://phabricator.kde.org/D8434 (see attachment). 
> Can you tell me how to get such a nice dependency tree for Review Requests?
>
> Best Regards,
> Sandro

this was a trick that one of my co-works told me:

I edited my ".gitconfig"

adding: post-review = rebase -i -x \"arc diff --head HEAD HEAD~1 && arc 
amend\"

Then I can use: git post-review <git-hash>

that will start a rebase process and will add "arc diff ..." after each 
commit allowing me to remove if or not.

--
On Donnerstag, 25. Januar 2018 16:04:03 CET Harald Sitter wrote:
> On Thu, Jan 25, 2018 at 3:00 PM, Michael Heidelbach <ottwolt@xxxxxxxxx> 
wrote:
> > Hi!
> > 
> > When I do
> > 
> > git checkout -b A origin/master
> > 
> > (changes)
> > 
> > git checkout -b B A
> > 
> > (changes)
> > 
> > 
> > git checkout A
> > 
> > arc diff
> > 
> > git checkout B
> > 
> > arc diff
> > 
> > Will phabricator show the relation of A and B? Is that a reasonable
> > approach, anyway?
> 
> Kind of. It's a bit fiddly but better than nothing I suppose...
> 
> See  git:branch-unique(*) docs
> https://secure.phabricator.com/book/phabricator/article/arcanist_commit_rang
> es/
> 
> git co master
> git co -b feature
> ...
> arc diff --base 'git:branch-unique(master)'
> git co -b subfeature
> ...
> arc diff --base 'git:branch-unique(master)'
> 
> Will create two different revisions. The first with the diff from
> master to feature and the second from feature to subfeature, via the
> webui you can then mark one revision as parent/child of the other
> which then makes them appear in order in the 'Stack' table above the
> diff.
> 
> e.g.
> https://phabricator.kde.org/D10094
> 
> note: for this to work you need to rebase feature onto subfeature
> whenever feature changes, the commits ancestry must be identical so
> arc can determine the base branch.
> 
> HS