Web lists-archives.com

Re: Dependent review requests




On Thu, Jan 25, 2018 at 3:00 PM, Michael Heidelbach <ottwolt@xxxxxxxxx> wrote:
> Hi!
>
> When I do
>
> git checkout -b A origin/master
>
> (changes)
>
> git checkout -b B A
>
> (changes)
>
>
> git checkout A
>
> arc diff
>
> git checkout B
>
> arc diff
>
> Will phabricator show the relation of A and B? Is that a reasonable
> approach, anyway?

Kind of. It's a bit fiddly but better than nothing I suppose...

See  git:branch-unique(*) docs
https://secure.phabricator.com/book/phabricator/article/arcanist_commit_ranges/

git co master
git co -b feature
...
arc diff --base 'git:branch-unique(master)'
git co -b subfeature
...
arc diff --base 'git:branch-unique(master)'

Will create two different revisions. The first with the diff from
master to feature and the second from feature to subfeature, via the
webui you can then mark one revision as parent/child of the other
which then makes them appear in order in the 'Stack' table above the
diff.

e.g.
https://phabricator.kde.org/D10094

note: for this to work you need to rebase feature onto subfeature
whenever feature changes, the commits ancestry must be identical so
arc can determine the base branch.

HS