Web lists-archives.com

Re: Kamoso in KDE Applications




On Tue, Jan 16, 2018 at 10:49 AM, Albert Astals Cid <aacid@xxxxxxx> wrote:
> El dilluns, 15 de gener de 2018, a les 4:05:05 CET, Aleix Pol va escriure:
>> On Sun, Jan 14, 2018 at 11:31 PM, Albert Astals Cid <aacid@xxxxxxx> wrote:
>> > El divendres, 12 de gener de 2018, a les 3:51:03 CET, Aleix Pol va
> escriure:
>> >> On Thu, Jan 11, 2018 at 7:44 PM, Albert Astals Cid <aacid@xxxxxxx> wrote:
>> >> > El dijous, 11 de gener de 2018, a les 17:01:52 CET, Aleix Pol va
> escriure:
>> >> >> Hey,
>> >> >> I'd like to move it there. It's in extragear/multimedia now and I keep
>> >> >> forgetting to release as often as I should.
>> >> >>
>> >> >> But the application is working, maintained and developed.
>> >> >>
>> >> >> Thoughts?
>> >> >
>> >> > I'm not vey happy about the copied code of QtGStreamer.
>> >> >
>> >> > Why did you decide to copy it?
>> >>
>> >> It's unmaintained, I had sent several fixes that went in but never got
>> >> released. So if you used it with master Kamoso worked but stable
>> >> didn't.
>> >
>> > Ok so you decided to fork it instead of becoming the upstream maintainer,
>> > fair enough i guess.
>> >
>> > But maybe you should rename
>> >
>> >    ./src/elements/gstqtvideosink/CMakeLists.txt:66:install(TARGETS gst$
>> >
>> > {QTVIDEOSINK_NAME} DESTINATION ${CMAKE_INSTALL_LIBDIR}/gstreamer-$
>> > {GSTREAMER_ABI_VERSION})
>> > so that it does not conflict with what other distros may be shipping from
>> > the "real" QtGStreamer ?
>>
>> I did, the code looks a bit weird but I didn't want to change it too
>> much from upstream.
>> We have this:
>> set(QTVIDEOSINK_NAME kamoso-qt5videosink)
>
> Ah, i see.
>
> Ok, personally i don't have any objection to adding yet another app to KDE
> Applications, anyone else has something to comment?

I can't see any issues with this, shall we proceed with the move in
say 24 hours?

>
> Cheers,
>   Albert

Cheers,
Ben

>
>>
>> > Also can you please get a build on https://build.kde.org/ going ?
>>
>> Yes, just requested it.
>>
>> Thanks!
>> Aleix
>
>