Re: Fwd: Waiting for a review
- Date: Mon, 26 Jun 2017 01:18:54 +0530
- From: Rishabh Gupta <rishabh9511@xxxxxxxxx>
- Subject: Re: Fwd: Waiting for a review
I'm not familiar with Qalcuate and its features and syntax. But let me ask a hypothetical question.
If I understand your change correctly, you still use libqalculate for plotting.
How do you handle the variables?Assume I add a new variable in a qalculate session in Cantor which will be defined in the external process you communicate now via QProcess with. This variable is known within this process only.
Variables are saved using qalc(the command line interface for Qalculate) and Cantor is aware of the variables that are saved through qalc.
What happens now if you use such a variable in a plot _expression_ (it it's possible at all)?
ATM there is no way to pass a variable saved through qalc to a plot _expression_.
The same question can be asked for custom functions
and maybe for some other situations where you have the problem to share the information between the external process and Cantor's process using libqalculate.
Anyway thank you for providing your input. I'll take care of the points you mentioned above
P.S.: BCCing kde-soc-management.
On 24.06.2017 18:11, Rishabh Gupta wrote:
---------- Forwarded message ----------
From: Rishabh Gupta <rishabh9511@xxxxxxxxx>
Date: Fri, Jun 23, 2017 at 10:28 PM
Subject: Waiting for a review
I am Rishabh, working on project Cantor under the guidance of Filipe Saraiva.I have been working according to the time line and most of what I proposed to do during the first month has been completed.
Few days back my mentor told me that he has got sick which eventually slowed things down. We communicated through emails where I kept him informed with what I was doing including the implementation details, but I haven't received any review yet
Before making any more changes I would want my code to be reviewed otherwise the diff will get too large