Web lists-archives.com

Re: kio-stash is in KDE Review




In the git repo all the files are permission executable, they shouldn't be.

There's no documentation.  I'm unsure how hard a requirement this is these days.

Use title case for name in src/iodaemon/stashnotifier.json

When I use Dolphin to copy a file over I get a dialog daying "Could
not copy.", some more information here might be useful.  The daemon
wasn't loaded.

Dolphin gains a Stash button which splits the view and opens Stash
kioslave.  I'd expect that clicking it again would close the view but
it doesn't. (Dolphin code)

There's no Messages.sh to extract the strings.

Consider asking VDG for a new icon for this in Dolphin, currently it
uses the folder icon which isn't very informative.

Copy of GPL 2 needed in top directory called COPYING.

Use the GPL header with the URL in it rather than postal address so it
doesn't get out of date if FSF moves
https://community.kde.org/Policies/Licensing_Policy#GPL_Header

Nudge the KDE neon developers to add a build to Neon

Jonathan



On 26 May 2017 at 18:25, Arnav Dhamija <arnav.dhamija@xxxxxxxxx> wrote:
> Hi!
>
> I had made the kio-stash ioslave last year as part of my GSoC 2016
> Project. Now that most of the changes which I wished to make in
> Dolphin relevant to the ioslave are part of master, I wish to ship the
> ioslave soon.
>
> The project is now in KDE review and is awaiting feedback. The link
> for the same can be found here:
> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672ac907b8
>
> The source of the project can be found here: https://cgit.kde.org/kio-stash.git/
>
> Thanks.
>
> --
> arnav dhamija