Re: We need to enable auto close in github pull requests
- Date: Wed, 29 Mar 2017 12:21:40 +0200
- From: "A. Bikadorov" <alex.bikadorov@xxxxxxxxxxx>
- Subject: Re: We need to enable auto close in github pull requests
On 29.03.2017 12:13, Luigi Toscano wrote:
> On Wednesday, 29 March 2017 12:10:58 CEST A. Bikadorov wrote:
>> On 29.03.2017 09:59, Ben Cooksley wrote:
>>> On Sun, Mar 26, 2017 at 6:21 AM, A. Bikadorov
>>>> If there is both, a README and README.md file in the repo, the README.md
>>>> is preferred for the "about" text of the project shown on Github. Which
>>>> means we could add a README.md with some standard text to every repo
>>>> only for Github.
>>>> The advantage is that contributors will (most likely) see this before
>>>> they create the pull request. (Or as an addition to a
>>>> PULL_REQUEST_TEMPLATE file and/or autoclose script).>
>>> Phabricator also displays .md files I believe, so this would cause
>>> those standard texts to be shown there.
>> Not if there is also a README file. See
>> https://phabricator.kde.org/source/krusader/ and
> In any case, why have to add another README in hundreds of repositories if we
> can do autoclosing in one shot?
Like I said: It can be an addition to autoclosing and contributors will see this before
they create the pull request. And it is a quickfix that devs can do right now for projects
which get a lot of pull requests on Github.
It is not *the ultimate best solution out there*.