Web lists-archives.com

Re: We need to enable auto close in github pull requests




On Sun, Mar 26, 2017 at 6:21 AM, A. Bikadorov
<alex.bikadorov@xxxxxxxxxxx> wrote:
> On 25.03.2017 18:06, Albert Astals Cid wrote:
>> El dissabte, 25 de març de 2017, a les 17:15:29 CET, Ralf Habacker va
>> escriure:
>>> Am 22.03.2017 um 07:55 schrieb Thiago Macieira:
>>>> Em segunda-feira, 13 de mar�o de 2017, �s 01:53:05 PDT, Ralf Habacker
>>>>
>>>> escreveu:
>>>>> Am 13.03.2017 um 00:31 schrieb Albert Astals Cid:
>>>>>> Looking at https://github.com/pulls?q=is%3Apr+org%3Akde+is%3Aopen makes
>>>>>> me
>>>>>> very sad seeing how there's people that want to contribute but will
>>>>>> never
>>>>>> get an answer.
>>>>>>
>>>>>> Even if you click to those 109 closed you can see how there are some
>>>>>> that
>>>>>> are from people that clearly got fed up from waiting.
>>>>>>
>>>>>> Please people that administer the github account (�Riddell?) make that
>>>>>> happen
>>>>>
>>>>> It may be unrelated but; At least for the github KDE/umbrello repo there
>>>>> is the following message displayed:  Only those with write access to
>>>>> this repository can merge pull requests.
>>>>> Looking at the related pull requests for umbrello they looks reasonable.
>>>>> Who is able to merge them ?
>>>>
>>>> That's the ntire point: *no* one is able to merge GitHub Pull Requests in
>>>> most of the repositories. That's by policy, since the submission should
>>>> go through Phabricator instead.
>>>
>>> Unfortunally people did not may be noticed about that policy on creating
>>> the pull request. Not better to use the github pull request template
>>> (see https://github.com/blog/2111-issue-and-pull-request-templates ) to
>>> inform them before creating an autoclosed request ?
>>
>> Obviously when i mean autoclosing i mean  close it and point them to the right
>> place, not just close it.
>>
>> Cheers,
>>   Albert
>>
>
> If there is both, a README and README.md file in the repo, the README.md is preferred for
> the "about" text of the project shown on Github. Which means we could add a README.md with
> some standard text to every repo only for Github.
>
> The advantage is that contributors will (most likely) see this before they create the pull
> request. (Or as an addition to a PULL_REQUEST_TEMPLATE file and/or autoclose script).

Phabricator also displays .md files I believe, so this would cause
those standard texts to be shown there.

>
> Cheers
> Alex

Cheers,
Ben