Re: Can anyone that cares about appdata please fix all these files?
- Date: Thu, 9 Mar 2017 16:46:08 +0100
- From: Harald Sitter <sitter@xxxxxxx>
- Subject: Re: Can anyone that cares about appdata please fix all these files?
FWIW, that's not true I fear.
When there is no summary *and* the desktop file has no Comment (which
ours usually do not do) then appstream-generator (the distro-level
aggregation tool for appstream data) will reject the data with the
error that there is no summary. In appstream-generator there's
enforcement of what is /sane/ data and so it tends to throw out
otherwise good data on the basis of what it considers sane.
On Mon, Feb 20, 2017 at 6:34 PM, Aleix Pol <aleixpol@xxxxxxx> wrote:
> On Sat, Feb 18, 2017 at 12:23 PM, Albert Astals Cid <aacid@xxxxxxx> wrote:
>> El divendres, 17 de febrer de 2017, a les 4:23:34 CET, Christoph Feck va
>>> On 17.02.2017 00:23, Albert Astals Cid wrote:
>>> > gwenview
>>> > https://build.kde.org/user/aacid/my-views/view/KDE%20Applications%2016.12/
>>> > job/gwenview%20Applications-16.12%20stable-kf5-qt5/PLATFORM=Linux,compiler
>>> > =gcc/lastCompletedBuild/testReport/(root)/TestSuite/appstreamtest/
>>> I checked the gwenview appdata.xml file, and indeed, there is no
>>> <summary> tag in it, unlike e.g. in Dolphin's file.
>>> These summaries are translated, so adding it to 16.12 branch would add a
>>> "new string", but if the failing test is considered a bug, I can do it
>>> in the 16.12 branch.
>> The problem is not the test failing, the problem is "is this actually needed
>> for whatever this file is used for?".
>> If apps that use those xml files are going to reject them because the tags are
>> missing, it obviously needs to be fixed in the release branch.
>>> Otherwise, I would just add <summary> to master branch.
> They won't be rejected, the UI will just have weird blank spaces.