Web lists-archives.com

Re: Merging KMag frameworks branch to master




Hi Ben,

It looks like that wont be needed actually. I had moved it to phabricator, just with a non obvious name. Here's my irc log:

[Tuesday, September 1, 2015] [5:54:21 PM MDT] <jpwhiting>   kdepepo: is kaccessible needed for kmag (or anything else) in Qt5/kf5 setup ?
[Tuesday, September 1, 2015] [5:54:49 PM MDT] <jpwhiting>   and what's the state of the kmag frameworks branch? is it "done" just needs merging or are there issues to fix still ?
[Tuesday, September 1, 2015] [5:57:32 PM MDT] <kdepepo> jpwhiting, not sure about kaccessible ... as far as I know, kmag links to qaccessibleclient, which is a lib in playground
[Tuesday, September 1, 2015] [5:58:56 PM MDT] <kdepepo> issues: https://paste.kde.org/pgvbptjnd
[Tuesday, September 1, 2015] [6:10:35 PM MDT] <jpwhiting>   hmm? which X11 includes are missing for kmousetool ?
[Tuesday, September 1, 2015] [6:10:42 PM MDT] <jpwhiting>   I built it here last week, /me looks
[Tuesday, September 1, 2015] [6:11:42 PM MDT] <jpwhiting>   kdepepo: ^^
[Tuesday, September 1, 2015] [6:12:22 PM MDT] <kdepepo> I don't remember exactly, but I think shumski complained
[Tuesday, September 1, 2015] [6:12:45 PM MDT] <jpwhiting>   k, I'll ask him
[Tuesday, September 1, 2015] [6:12:47 PM MDT] <jpwhiting>   thanks
[Tuesday, September 1, 2015] [6:15:23 PM MDT] <kdepepo> jpwhiting, looking at my changes, I have a find_package(X11) there, but nothing which adds the X11 include dirs to the include path.
[Tuesday, September 1, 2015] [6:16:22 PM MDT] <jpwhiting>   target_link_libraries should be adding include paths now iirc
[Tuesday, September 1, 2015] [6:16:37 PM MDT] <kdepepo> hm, and it actually only needs libXtst, not X11 ... not sure if the cmake stuff is correct
[Tuesday, September 1, 2015] [6:17:18 PM MDT] <jpwhiting>   ah, probably doesn't need all of the ${X11_LIBRARIES} then?
[Tuesday, September 1, 2015] [7:21:55 PM MDT] <jpwhiting>   kdepepo: I'm beginning to think that either a todo.kde.org or a workboard on phabricator would be good to track what is left to d
o re porting to Qt5/kf5
[Tuesday, September 1, 2015] [7:22:19 PM MDT] <jpwhiting>   http://developer.kde.org/~cfeck/portingstatus.html is good, but only shows what's been merged/committed, not what's in progress a
nd by whom
[Friday, September 4, 2015] [2:15:52 PM MDT] <kde__pepo>    removing the fixx11 include compiles without errors.
[Friday, September 4, 2015] [2:16:00 PM MDT] <jpwhiting>    ok, ship it! :)
[Friday, September 4, 2015] [2:17:24 PM MDT] <pursuivant>   ^Bkmousetool^B ^C5(frameworks)^C ^C12v15.04.1-10-gac639c4^C * ^C3Christoph Feck^C: kmousetool/kmousetool.cpp
[Friday, September 4, 2015] [2:17:24 PM MDT] <pursuivant>   Remove obsolete #include <fixx11h.h>
[Friday, September 4, 2015] [2:17:25 PM MDT] <pursuivant>   http://commits.kde.org/kmousetool/ac639c429b209bb95beb0d3c79ffa18cc470b452
[Friday, September 4, 2015] [2:18:09 PM MDT] Quit   pursuivant (pursuivant@kde/bot/commit-notifications) has left this server (Quit: transmission timeout).
[Friday, September 4, 2015] [2:18:33 PM MDT] <kde__pepo>    I haven't had time yet to check how the reverse AA scaler can be added to kmag.
[Friday, September 4, 2015] [2:19:02 PM MDT] <kde__pepo>    Currently it simply zooms by setting a scale matrix.
[Friday, September 4, 2015] [2:19:15 PM MDT] <jpwhiting>    I suggest we add it to the kmag TODO file if it has one, but I don't think that should block frameworks getting merged to master
[Friday, September 4, 2015] [2:19:16 PM MDT] <jpwhiting>    imo
[Friday, September 4, 2015] [2:19:40 PM MDT] <kde__pepo>    right, what I posted was my todo list :P
[Friday, September 4, 2015] [2:19:44 PM MDT] <jpwhiting>    ah, ok
[Friday, September 4, 2015] [2:20:07 PM MDT] <jpwhiting>    I started putting your todo list on https://phabricator.kde.org/tag/qt_5_porting/ :)
[Friday, September 4, 2015] [2:21:18 PM MDT] <kde__pepo>    kmag mode not saved is bug 332303
[Friday, September 4, 2015] [2:24:40 PM MDT] <jpwhiting>    k, added

So tldr the list is alive here: https://phabricator.kde.org/tag/qt_5_porting/

thanks,
Jeremy

On Mon, Mar 6, 2017 at 11:45 PM, Ben Cooksley <bcooksley@xxxxxxx> wrote:
On Tue, Mar 7, 2017 at 4:19 PM, Jeremy Whiting <jpwhiting@xxxxxxx> wrote:
> It looks like todo.kde.org is down or no longer a thing. I thought I moved
> the list to phabricator, but can't seem to find it on there either.

Hi Jeremy,

todo.kde.org was phased out a while back after a notified period for migrations.
Sysadmin have since archived the site in long term storage.

If necessary we can probably bring it online temporarily in order for
a migration to Phabricator to be made for these tasks.
Please file a Sysadmin task if we need to do that.

Cheers,
Ben

>
> On Mon, Mar 6, 2017 at 2:56 PM, Albert Astals Cid <aacid@xxxxxxx> wrote:
>>
>> El dilluns, 6 de març de 2017, a les 1:29:32 CET, Christoph Feck va
>> escriure:
>> > On 05.03.2017 23:59, Albert Astals Cid wrote:
>> > > I had a quick look and features seem to work as good/bad in the
>> > > frameworks
>> > > branch as in master.
>> > >
>> > > If noone disagrees I'll do the merge on March 13th.
>> >
>> > Jeremy Whiting had a list somewhere on todo.kde.org with tasks that
>> > blocked merging. I only remember two, because I was responsible for
>> > them, but I think there were more.
>>
>> Does anyone have a link to that list? Wouldn't want to force a merge
>> that's
>> not ready :)
>>
>> Cheers,
>>   Albert
>>
>> >
>> > First, I did not correctly port the saving to remote image via KIO.
>> > Someone familiar with KIO could look at
>> >
>> > https://cgit.kde.org/kmag.git/commit/?h=frameworks&id=daa05153573ace5bb76479
>> > 71a7a21dc724777a4f and correct it.
>> >
>> > Second,
>> >
>> > https://cgit.kde.org/kmag.git/commit/?h=frameworks&id=1f8e4208d72c7f9ce6fa73
>> > 9f477151aab1fadccf enabled building against QAccessibilityClient, but I
>> > could not test it.
>>
>>
>