Web lists-archives.com

Re: Review Request 128664: Nested tags for Baloo

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/

On September 23rd, 2016, 2:46 p.m. IST, Boudhayan Gupta wrote:

Diff looks sane to me, and the feature seems useful in theory.

Will this require a reindexing? Seems to me from previous comments made by vHanda that there's a schema change involved?

On September 23rd, 2016, 8 p.m. IST, James Smith wrote:

Yes. The full tag is stored in its own prefix.

On September 24th, 2016, 3:36 a.m. IST, Boudhayan Gupta wrote:

Right. In that case, hold this for a while. I may end up changing LMDB for a different key-value database, and that will require reindexing. Let's try to bunch all changes that require a reindexing together.

On February 5th, 2017, 8:57 a.m. IST, James Smith wrote:

As of Rev. 6, the tag doesn't need it's own prefix, the existing bool term is used instead. Is there any other reason holding this back from merging?

Baloo isn't strictly maintained properly, so if it works and no one objects in say, 2 weeks, merge it.

- Boudhayan

On December 2nd, 2016, 7:34 a.m. IST, James Smith wrote:

Review request for Baloo and Boudhayan Gupta.
By James Smith.

Updated Dec. 2, 2016, 7:34 a.m.

Bugs: 334615
Repository: baloo


Index and query each tag as a single full term for generating recursed search results. Represent nested tags as recursed items in the Tags:// KIO Slave.


Compile, run


  • autotests/unit/file/basicindexingqueuetest.cpp (71689b22f03688b54fc292746afbff672a5a63e8)
  • src/file/basicindexingjob.cpp (88bb59a01e5592abb74b1ab345bfc6765d35db57)
  • src/kioslaves/tags/kio_tags.cpp (de2e6d71945632e23a85f831878b4c431360731c)
  • src/lib/searchstore.cpp (060a4fd795ab858eb84526f93f827d09ee85db7c)

View Diff