Web lists-archives.com

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129798/

This change has been marked as submitted.


Review request for Baloo and KDE Frameworks.
By Matthieu Gallien.

Updated Feb. 5, 2017, 4:30 p.m.

Changes

Submitted with commit 35ea63920a0398aa859b2944770fd9036c271166 by Matthieu Gallien to branch master.
Repository: kfilemetadata

Description

Musepack extraction of album artist was using the wrong tag name (tested against easytag and picard).

See also this page (http://taglib.org/api/classTagLib_1_1APE_1_1Tag.html) that seems to indicate that APE is using "ALBUM ARTIST" with a space between both words.

Testing

I have tested with automatic tests of KFileMetaData and also the encoding problem in Musepack format against Easytag and Picard applications.

Diffs

  • autotests/samplefiles/test.flac (PRE-CREATION)
  • autotests/samplefiles/test.m4a (PRE-CREATION)
  • autotests/samplefiles/test.mp3 (PRE-CREATION)
  • autotests/samplefiles/test.mpc (PRE-CREATION)
  • autotests/samplefiles/test.ogg (PRE-CREATION)
  • autotests/taglibextractortest.cpp (d46e49e)
  • src/extractors/taglibextractor.cpp (8fcad93)

View Diff