Web lists-archives.com

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129798/

Ship it!

Patch looks ok to me, although I don't know much about all this.

The real problem isn't tooling, but lack of active maintainership for kfilemetadata. Are you interested in taking over?

- David Faure

On January 15th, 2017, 3:03 p.m. UTC, Matthieu Gallien wrote:

Review request for Baloo and KDE Frameworks.
By Matthieu Gallien.

Updated Jan. 15, 2017, 3:03 p.m.

Repository: kfilemetadata


Musepack extraction of album artist was using the wrong tag name (tested against easytag and picard).

See also this page (http://taglib.org/api/classTagLib_1_1APE_1_1Tag.html) that seems to indicate that APE is using "ALBUM ARTIST" with a space between both words.


I have tested with automatic tests of KFileMetaData and also the encoding problem in Musepack format against Easytag and Picard applications.


  • autotests/samplefiles/test.flac (PRE-CREATION)
  • autotests/samplefiles/test.m4a (PRE-CREATION)
  • autotests/samplefiles/test.mp3 (PRE-CREATION)
  • autotests/samplefiles/test.mpc (PRE-CREATION)
  • autotests/samplefiles/test.ogg (PRE-CREATION)
  • autotests/taglibextractortest.cpp (d46e49e)
  • src/extractors/taglibextractor.cpp (8fcad93)

View Diff