Web lists-archives.com

Re: Review Request 128664: Nested tags for Baloo




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/

On September 23rd, 2016, 3:16 a.m. MDT, Boudhayan Gupta wrote:

Diff looks sane to me, and the feature seems useful in theory.

Will this require a reindexing? Seems to me from previous comments made by vHanda that there's a schema change involved?

On September 23rd, 2016, 8:30 a.m. MDT, James Smith wrote:

Yes. The full tag is stored in its own prefix.

On September 23rd, 2016, 4:06 p.m. MDT, Boudhayan Gupta wrote:

Right. In that case, hold this for a while. I may end up changing LMDB for a different key-value database, and that will require reindexing. Let's try to bunch all changes that require a reindexing together.

As of Rev. 6, the tag doesn't need it's own prefix, the existing bool term is used instead. Is there any other reason holding this back from merging?


- James


On December 1st, 2016, 7:04 p.m. MST, James Smith wrote:

Review request for Baloo and Boudhayan Gupta.
By James Smith.

Updated Dec. 1, 2016, 7:04 p.m.

Bugs: 334615
Repository: baloo

Description

Index and query each tag as a single full term for generating recursed search results. Represent nested tags as recursed items in the Tags:// KIO Slave.

Testing

Compile, run

Diffs

  • autotests/unit/file/basicindexingqueuetest.cpp (71689b22f03688b54fc292746afbff672a5a63e8)
  • src/file/basicindexingjob.cpp (88bb59a01e5592abb74b1ab345bfc6765d35db57)
  • src/kioslaves/tags/kio_tags.cpp (de2e6d71945632e23a85f831878b4c431360731c)
  • src/lib/searchstore.cpp (060a4fd795ab858eb84526f93f827d09ee85db7c)

View Diff