Web lists-archives.com

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/

On Януари 9th, 2017, 9:22 след обяд EET, Stefan Brüns wrote:

src/file/extractor/app.cpp (Diff revision 3)
81
        int delay = m_idleMonitor.isIdle() ? 0 : 10;
81
        int delay = m_idleMonitor.isIdle() ? 0 : 32;

Bogus constant

I want to be > 10


On Януари 9th, 2017, 9:22 след обяд EET, Stefan Brüns wrote:

src/file/extractor/app.cpp (Diff revision 3)
165
            break; // we are done with extraction, it can now stop safety

Thats plain wrong, results from multiple extractors are combined!

I'm waiting to see a extractor relationship.


- Anthony


On Януари 9th, 2017, 7:48 преди обяд EET, Anthony Fieroni wrote:

Review request for Baloo, Boudhayan Gupta, Pinak Ahuja, and Vishesh Handa.
By Anthony Fieroni.

Updated Ян. 9, 2017, 7:48 преди обяд

Repository: baloo

Description

Processing large directories, +5000 files, can be CPU eater. Large file, itself, can be another issue.

Diffs

  • src/file/extractor/app.cpp (97332469)
  • src/file/extractor/result.h (c800b0dd)
  • src/file/extractor/result.cpp (072aebc6)
  • src/tools/balooctl/indexer.cpp (45e42c1c)

View Diff