Web lists-archives.com

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/

On Януари 9th, 2017, 8:50 след обяд EET, Albert Astals Cid wrote:

src/tools/balooctl/indexer.cpp (Diff revision 3)
            break; // we are done with extraction, it can now stop safety

Why? Aren't extractors independent? What has one giving no output have to do with the next giving output or not?

They are independent, potentially first extractor should be enough, but it may change previous behavior if we stop after him. Note https://git.reviewboard.kde.org/r/129720/ after all i try to improve situation, but it can cause side effect.

- Anthony

On Януари 9th, 2017, 7:48 преди обяд EET, Anthony Fieroni wrote:

Review request for Baloo, Boudhayan Gupta, Pinak Ahuja, and Vishesh Handa.
By Anthony Fieroni.

Updated Ян. 9, 2017, 7:48 преди обяд

Repository: baloo


Processing large directories, +5000 files, can be CPU eater. Large file, itself, can be another issue.


  • src/file/extractor/app.cpp (97332469)
  • src/file/extractor/result.h (c800b0dd)
  • src/file/extractor/result.cpp (072aebc6)
  • src/tools/balooctl/indexer.cpp (45e42c1c)

View Diff