Web lists-archives.com

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/

Without knowing anything about baloo this looks totally wrong

QList<KFileMetaData::Extractor*> exList = m_extractorCollection.fetchExtractors(mimetype);

why would not you want to iterate over all the iterators that support a given mimetype?


- Albert Astals Cid


On December 27th, 2016, 5:34 a.m. UTC, Anthony Fieroni wrote:

Review request for Baloo and Vishesh Handa.
By Anthony Fieroni.

Updated Dec. 27, 2016, 5:34 a.m.

Repository: baloo

Description

Processing large directories, +5000 files, can be CPU eater. Large file, itself, can be another issue.

Diffs

  • src/file/extractor/app.cpp (97332469)
  • src/tools/balooctl/indexer.cpp (45e42c1c)

View Diff