Web lists-archives.com

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/

On Декември 26th, 2016, 2:24 преди обяд EET, Aleix Pol Gonzalez wrote:

src/file/extractor/app.cpp (Diff revision 1)
81
        int delay = m_idleMonitor.isIdle() ? 0 : 10;
81
        int delay = m_idleMonitor.isIdle() ? 0 : 32;

Why is 32 better than 10?

It can be better only in corner cases, i.e. other CPU eater process works at same time. Main problem is that KFileMetadata::fetchExtractors returns all known extractors for unsported mimetype https://api.kde.org/frameworks/kfilemetadata/html/extractorcollection_8cpp_source.html#l00143


On Декември 26th, 2016, 2:24 преди обяд EET, Aleix Pol Gonzalez wrote:

src/file/extractor/app.cpp (Diff revision 1)
85
        QString url = QFile::decodeName(m_tr->documentUrl(id));
85
        QString url = QFile::decodeName(m_tr->documentUrl(id));

FWIW, something looks incorrect here, as it seems be using Urls as paths. I know it's unrelated but maybe you can check?

QByteArray Transaction::documentUrl(quint64 id) const Url is stored as QByteArray in db, it looks correct.


- Anthony


On Декември 25th, 2016, 3:27 след обяд EET, Anthony Fieroni wrote:

Review request for Baloo and Vishesh Handa.
By Anthony Fieroni.

Updated Дек. 25, 2016, 3:27 след обяд

Repository: baloo

Description

Processing large directories, +5000 files, can be CPU eater. Large file, itself, can be another issue.

Diffs

  • src/file/extractor/app.cpp (97332469)

View Diff