Web lists-archives.com

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/

src/file/extractor/app.cpp (Diff revision 1)
81
        int delay = m_idleMonitor.isIdle() ? 0 : 10;
81
        int delay = m_idleMonitor.isIdle() ? 0 : 32;

Why is 32 better than 10?


src/file/extractor/app.cpp (Diff revision 1)
85
        QString url = QFile::decodeName(m_tr->documentUrl(id));
85
        QString url = QFile::decodeName(m_tr->documentUrl(id));

FWIW, something looks incorrect here, as it seems be using Urls as paths. I know it's unrelated but maybe you can check?


- Aleix Pol Gonzalez


On December 25th, 2016, 2:27 p.m. CET, Anthony Fieroni wrote:

Review request for Baloo and Vishesh Handa.
By Anthony Fieroni.

Updated Dec. 25, 2016, 2:27 p.m.

Repository: baloo

Description

Processing large directories, +5000 files, can be CPU eater. Large file, itself, can be another issue.

Diffs

  • src/file/extractor/app.cpp (97332469)

View Diff