Web lists-archives.com

Re: Review Request 129546: DBus-parts of baloo don't depend on inotify




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129546/

This change has been marked as submitted.


Review request for Baloo.
By Adriaan de Groot.

Updated Dec. 25, 2016, 10:22 p.m.

Changes

Submitted with commit a8db82a44470db8e847409b2ce5a6a593945de52 by Adriaan de Groot to branch master.
Repository: baloo

Description

The src/dbus directory was only added to the build if BUILD_KINOTIFY is on. But the DBus bits don't depend on inotify, and besides the DBus bits are mandatory for other parts of baloo (e.g. lib/indexerconfig.cpp includes maininterface.h unconditionally).

So move add_subdirectory(dbus) outside of the if() that it doesn't belong in.

Testing

Baloo now actually builds on FreeBSD.

Diffs

  • src/CMakeLists.txt (529b786)

View Diff