Web lists-archives.com

Re: Review Request 129545: CMake: fix LMDB detection and use




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129545/

This change has been marked as submitted.


Review request for Baloo.
By Adriaan de Groot.

Updated Dec. 17, 2016, 10:32 p.m.

Changes

Submitted with commit 3a9643c139531a50caf2473bd65b33ad9490037f by Adriaan de Groot to branch master.
Repository: baloo

Description

CMake: fix LMDB detection and use

Testing

This fixes a compile failure found by the KDE-CI system on FreeBSD (url includes spaces): https://build-sandbox.kde.org/view/FreeBSD/job/baloo kf5-qt5 devel master FreeBSD clang/7/console

10:19:36 /home/kde/sources/kf5-qt5/baloo/src/engine/positiondb.h:29:10: fatal error: 'lmdb.h' file not found

This happens because the directory in which LMDB is found is not added to the include search path; this patch fixes that. At the same time, this patch modifies the FindLMDB.cmake module to follow best-practices in writing Find modules, http://www.vtk.org/Wiki/CMake:How_To_Find_Libraries , use <foo>_INCLUDE_DIRS instead of <foo>_INCLUDE_DIR

Diffs

  • CMakeLists.txt (299509c)
  • cmake/FindLMDB.cmake (3dc8b77)

View Diff