Web lists-archives.com

Re: Review Request 129349: [baloo] add (and use) FileIndexerConfig::shouldFileBeIndexed(const QStringRef&)




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129349/

On Dezember 13th, 2016, 3:08 vorm. UTC, Aleix Pol Gonzalez wrote:

src/kioslaves/timeline/timelinetools.cpp (Diff revision 2)
98
        QStringList sections = path.split(QStringLiteral("/"), QString::SkipEmptyParts);
98
        const QStringList sections = path.split(QStringLiteral("/"), QString::SkipEmptyParts);

Use split(QLatin1Char('/'),...) Also this can be changed into splitRef?

I thought about this too but since s_dateRegexp is a QRegExp (and not a QRegularExpression) I thought that the outcome is not worth the change. Maybe I should change s_dateRegexp to a QRegularExpression ...


- Christian


On Dezember 12th, 2016, 6:48 nachm. UTC, Christian Ehrlicher wrote:

Review request for Baloo.
By Christian Ehrlicher.

Updated Dez. 12, 2016, 6:48 nachm.

Repository: baloo

Description

Use the new QStringRef class to avoid creation of temporary QString objects. Since every filename is sent through FileIndexerConfig::shouldFileBeIndexed(), I think this is a good optimization although now there are two functions for FileIndexerConfig::shouldFileBeIndexed() and RegExpCache::exactMatch() - one with QString and one with QStringRef ...

Diffs

  • src/engine/queryparser.cpp (d096bf3)
  • src/file/fileindexerconfig.h (10eacd5)
  • src/file/fileindexerconfig.cpp (0e4f4c4)
  • src/file/modifiedfileindexer.cpp (d1f5011)
  • src/file/newfileindexer.cpp (7e19622)
  • src/file/regexpcache.h (60d370d)
  • src/file/regexpcache.cpp (61f07d6)
  • src/file/xattrindexer.cpp (3daecef)
  • src/kioslaves/tags/kio_tags.cpp (de2e6d7)
  • src/kioslaves/timeline/timelinetools.cpp (26e44ee)

View Diff