Web lists-archives.com

Re: Review Request 129605: Move the Baloo database into the XDG cache path.




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129605/

On December 5th, 2016, 5:34 a.m. MST, Pinak Ahuja wrote:

On second thought I'm not too sure if the Cache dir's are more appropriate for the Database. According to the spec "$XDG_CACHE_HOME defines the base directory relative to which user specific non-essential data files should be stored. If $XDG_CACHE_HOME is either not set or empty, a default equal to $HOME/.cache should be used." it is the location where non essential data files should be stored. The database is an essential file for baloo to function so I'm not sure if we should put it in the cache dir.

The Baloo database is automatically generated if it's not found where it was put. The Baloo database is a cache containing non-essential data, if the db is deleted it will be recreated and repopulated with the same dataset it had before removal.


- James


On December 3rd, 2016, 9 p.m. MST, James Smith wrote:

Review request for Baloo.
By James Smith.

Updated Dec. 3, 2016, 9 p.m.

Repository: baloo

Description

Move the database into the XDG cache path.

Testing

Compile, run.

Diffs

  • src/engine/global.cpp (4f511ac08f0fd18bd3c78b794f4ba7ccef88e75b)
  • src/tools/balooctl/main.cpp (2a6b175ee599d7ca713adcbed80d3bd128e9dd63)

View Diff