Web lists-archives.com

Re: Review Request 129549: Check more thoroughly for inotify




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129549/

On November 23rd, 2016, 2:41 p.m. UTC, Aleix Pol Gonzalez wrote:

CMakeLists.txt (Diff revision 1)
71
    set(BUILD_KINOTIFY ${INOTIFY_FOUND})

Variables in cmake are case-sensitive. It should be the same as what you pass to find_package: ${Inotify_FOUND}.

(if that's not what the Find*.cmake file is doing, I'd consider it a bug)

You're right .. and it isn't, so I'll comment on the review for the Find(Lib)Inotify module as well and update this one later.


- Adriaan de


On November 23rd, 2016, 2:06 p.m. UTC, Adriaan de Groot wrote:

Review request for Baloo.
By Adriaan de Groot.

Updated Nov. 23, 2016, 2:06 p.m.

Repository: baloo

Description

Don't just assume that Linux has inotify and nobody else does. Instead, check for inotify on non-Linux systems and if found, use it.

This depends on https://git.reviewboard.kde.org/r/129316/ to actually get the Inotify cmake-module.

Testing

This way, FreeBSD (which gets inotify support through libinotify) finds inotify, enables support for it, and then builds all the bits of baloo that depend on inotify. This is already done in the FreeBSD packaging.

Diffs

  • CMakeLists.txt (299509c6bd113c7d78ebdae3806bdd2fb0077fad)
  • src/file/CMakeLists.txt (767e7dc62e8f15e4ce545becc0a32a0d038dda69)

View Diff