Web lists-archives.com

Re: Review Request 129548: Check more thoroughly for inotify

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129548/

This change has been discarded.

Review request for Baloo.
By Adriaan de Groot.

Updated Nov. 23, 2016, 2:02 p.m.

Repository: baloo


Don't just assume that Linux has inotify and nobody else does. Instead, check for inotify on non-Linux systems and if found, use it.

This depends on https://git.reviewboard.kde.org/r/129316/ to actually get the Inotify cmake-module.


This way, FreeBSD (which gets inotify support through libinotify) finds inotify, enables support for it, and then builds all the bits of baloo that depend on inotify. This is already done in the FreeBSD packaging.


  • src/codecs/coding.h (3d55a401aef0d797a62c18f886e8488079ff30c8)
  • src/codecs/coding.cpp (73e2fa29a83b1104043b00d4e03e4ea40326253f)
  • src/codecs/positioncodec.cpp (22f489528d1a6b27299333ba730a3e63390e0cfa)

View Diff