Web lists-archives.com

Re: Review Request 129379: [baloo] Remove unused functions

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129379/

This change has been marked as submitted.

Review request for Baloo and David Faure.
By Christian Ehrlicher.

Updated Nov. 15, 2016, 7:58 p.m.


Submitted with commit e40689fb56fbcd12ca4eeaef1b44e93f5afc6d7d by Christian Ehrlicher to branch master.
Repository: baloo


As discussed in REVIEW 129186 there is a lot of bit rotting in coding.cpp/.h. With this patch I removed all the unused stuff and moved out a temporary buffer to avoid reallocating this buffer on every call to putDifferentialVarInt32()


Unittests still working as expected


  • src/codecs/coding.h (3d55a40)
  • src/codecs/coding.cpp (73e2fa2)
  • src/codecs/positioncodec.cpp (22f4895)

View Diff