Web lists-archives.com

Re: Review Request 129379: [baloo] Remove unused functions

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129379/

Fix it, then Ship it!

src/codecs/coding.cpp (Diff revision 1)
void putVarint32(QByteArray* dst, quint32 v)
void putDifferentialVarInt32(QByteArray &baTmp, QByteArray* dst, const QVector<quint32>& values)

Can you document the method? Somewhat unusual API, given that it writes to both baTmp and dst :)

src/codecs/positioncodec.cpp (Diff revision 1)
    QByteArray temporayStorage;

typo: missing r before y

- David Faure

On November 11th, 2016, 5:09 p.m. UTC, Christian Ehrlicher wrote:

Review request for Baloo and David Faure.
By Christian Ehrlicher.

Updated Nov. 11, 2016, 5:09 p.m.

Repository: baloo


As discussed in REVIEW 129186 there is a lot of bit rotting in coding.cpp/.h. With this patch I removed all the unused stuff and moved out a temporary buffer to avoid reallocating this buffer on every call to putDifferentialVarInt32()


Unittests still working as expected


  • src/codecs/coding.h (3d55a40)
  • src/codecs/coding.cpp (73e2fa2)
  • src/codecs/positioncodec.cpp (22f4895)

View Diff