Web lists-archives.com

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/

I wouldn't discard it, I'm afraid nobody really wants to take responsibility though. I'd say that if you plan to maintain it you can commit it.


- Aleix Pol Gonzalez


On November 6th, 2016, 12:39 a.m. CET, Christian Ehrlicher wrote:

Review request for Baloo, KDE Frameworks and Vishesh Handa.
By Christian Ehrlicher.

Updated Nov. 6, 2016, 12:39 a.m.

Repository: baloo

Description

This patch speeds up PostingCodec::encode() by a factor of ~4 by not adding every single encoded int32 to the resulting bytearray which results in a lot of small memcpy operations. The idea is to use a preallocated QByteArray and directly encode the integers into this buffer. This makes the code a little bit more complex but the speedup should be gain enough for this.

Ping! No interest in this patch? Should I discard it?

Testing

positoncodectest calculates the same md5sum as before.

Diffs

  • src/codecs/coding.cpp (5961077)

View Diff