Web lists-archives.com

Re: Review Request 129185: [baloo] Add a small benchmark for PositionCodec::encode()

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129185/

Review request for Baloo.
By Christian Ehrlicher.

Updated Oct. 17, 2016, 5:59 p.m.


Found out that there was already a small benchmark but imo the usecase (very few positions in a file) is no real-world example - at least during my debugging I there were at least 1k positions. Therefore I added my data too. I also added a small unit test to check the encoded/decoded output in autotests/unit/codec

Repository: baloo


This small test is used to test if the changes inside PostingCodec::encode() do not break anything. It also does some benchmarking to show the speedup.

Diffs (updated)

  • autotests/benchmarks/positioncodecbenchmark.cpp (e7aeebf)
  • autotests/unit/codecs/CMakeLists.txt (f65d633)
  • autotests/unit/codecs/positioncodectest.cpp (PRE-CREATION)

View Diff