Web lists-archives.com

Re: Review Request 129182: [baloo] CLazy fixes: use const ref in for loop instead object




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129182/

Fix it, then Ship it!

src/engine/transaction.cpp (Diff revision 2)
459
    for (auto list : allLists) {
458
    Q_FOREACH (const auto& list , map) {

no space before the coma


- Aleix Pol Gonzalez


On October 14th, 2016, 11:11 p.m. CEST, Christian Ehrlicher wrote:

Review request for Baloo.
By Christian Ehrlicher.

Updated Oct. 14, 2016, 11:11 p.m.

Repository: baloo

Description

While trying to figure out why indexing my files is so slow, I compiled baloo on my system with clazy and found some unnecessary copies in foreach loops. It's not related to my problem and not really a performance critical part but imo should be fixed anyway

Testing

Compiles fine

Diffs

  • src/engine/transaction.cpp (908a81f)
  • src/file/fileindexerconfig.cpp (ccb5d80)
  • src/file/pendingfilequeue.cpp (489f100)
  • tests/file/storagedevicestest.cpp (f269c81)

View Diff