Web lists-archives.com

Re: Review Request 129182: CLazy fixes: use const ref in for loop instead object




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129182/

On October 14th, 2016, 8:58 p.m. UTC, Aleix Pol Gonzalez wrote:

src/engine/transaction.cpp (Diff revision 1)
457
    QList<PostingList> allLists = map.values();
457
    QList<PostingList> allLists = map.values();

add const

The question here is - why create a temporary QList here at all - I'm now using Q_FOREACH on the map directly


- Christian


On October 14th, 2016, 9:11 p.m. UTC, Christian Ehrlicher wrote:

Review request for Baloo.
By Christian Ehrlicher.

Updated Oct. 14, 2016, 9:11 p.m.

Repository: baloo

Description

While trying to figure out why indexing my files is so slow, I compiled baloo on my system with clazy and found some unnecessary copies in foreach loops. It's not related to my problem and not really a performance critical part but imo should be fixed anyway

Testing

Compiles fine

Diffs

  • src/engine/transaction.cpp (908a81f)
  • src/file/fileindexerconfig.cpp (ccb5d80)
  • src/file/pendingfilequeue.cpp (489f100)
  • tests/file/storagedevicestest.cpp (f269c81)

View Diff