Web lists-archives.com

Re: Review Request 129183: [baloo] CLazy fixes: removed unused member var, add Q_OBJECT




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129183/

src/file/extractor/iohandler.h (Diff revision 1)
34
    IOHandler(int stdin, int stdout);
34
    IOHandler(int stdin, int);

That doesn't look right. It's not exported, we can have BIC changes.


- Aleix Pol Gonzalez


On October 14th, 2016, 10:58 p.m. CEST, Christian Ehrlicher wrote:

Review request for Baloo.
By Christian Ehrlicher.

Updated Oct. 14, 2016, 10:58 p.m.

Repository: baloo

Description

CLayz warns about an unused member var in IOHandler and a missing Q_OBJECT macro in TimeEstimator which produces a lot of noise in the compile output.

Testing

Compiles fine

Diffs

  • src/file/extractor/iohandler.h (c0dfbbb)
  • src/file/extractor/iohandler.cpp (b49a2b2)
  • src/file/timeestimator.h (11137d3)

View Diff