Web lists-archives.com

Re: Review Request 128738: Quote all prefix search values, if operator is = or :.

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128738/

On September 4th, 2016, 9:25 a.m. UTC, Vishesh Handa wrote:

This breaks the default behavior of searching and makes it hard to reason what is going on.

Eg - baloosearch 'tag:Death Fire' and baloosearch tag:Death Fire now yield different results since "Fire" is considered part of the tag in the first query.

I would rather not ship this.

'tag:Death Fire' and tag:Death Fire are invalid (or poorly-written and poorly intended) resolves, tag:\"Death Fire\" is an equivalent for the first query. Or, for the second, tag="Death" OR tag="Fire" would return matches for both tags. The use of prefix and operators jargon is near-mandatory for good results, and conjunctory statements are sometimes required; similarly consistent parsing cultivates a much better understanding of how to obtain optimal search results.

The biggest annoyance that this patch fixes is the lack of results from searching for a tag with a space immediately following a successful search for a tag with no spaces and no escaped quotes. e.g.

tag="Water" or tag=Water : has matches tag="Death Water" or tag=Death Water : no matches. Requirement to abandon existing "working" syntax, forced to write tag=/"Death Water/".

Noticeably this is not an intuitive behaviour.

- James

On August 24th, 2016, 3:26 p.m. UTC, James Smith wrote:

Review request for Baloo and Vishesh Handa.
By James Smith.

Updated Aug. 24, 2016, 3:26 p.m.

Repository: baloo


Add quotation marks surrounding the search term for all searches matching operator = or :.


Compile, run.


  • src/tools/baloosearch/main.cpp (8fabdbb)

View Diff