Web lists-archives.com

Re: Review Request 128738: Quote all prefix search values, if operator is = or :.




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128738/

On August 29th, 2016, 8:13 a.m. UTC, Pinak Ahuja wrote:

Hi, could you add a little more details as to why this is needed/what cases it improves or fixes. And maybe some unit tests would be nice. :)

The arguments with quotes are stripped by the shell, breaking any results for queries with spaces. This patch encapsulates arguments with a recognized search operator and prefix into quotation marks, allowing multi-word match results.

This is a no-brainer improvement over escaping the quotes on the search line, which following a prefix and operator should not be without surrounding quotes anyway.


- James


On August 24th, 2016, 3:26 p.m. UTC, James Smith wrote:

Review request for Baloo and Vishesh Handa.
By James Smith.

Updated Aug. 24, 2016, 3:26 p.m.

Repository: baloo

Description

Add quotation marks surrounding the search term for all searches matching operator = or :.

Testing

Compile, run.

Diffs

  • src/tools/baloosearch/main.cpp (8fabdbb)

View Diff