Web lists-archives.com

Re: Re-enable new_delete_type_mismatch in ASAN?




On Tue, Aug 16, 2016 at 9:34 AM, Albert Astals Cid <aacid@xxxxxxx> wrote:
> El dijous, 4 d’agost de 2016, a les 19:40:14 CEST, Ben Cooksley va escriure:
>> On Thu, Aug 4, 2016 at 9:52 AM, Albert Astals Cid <aacid@xxxxxxx> wrote:
>> > We disabled the new_delete_type_mismatch ASAN check a while ago because Qt
>> > was at fault and creating "false positives" in our code.
>> >
>> > Since then the Qt code has been fixed (i think), so should we re-enable
>> > the
>> > check?
>>
>> We currently run Qt 5.6 and 5.7 on the CI system, using Git revisions
>> 6fbf179f7396cf544dd7c204b619dc3552e2bfb0 and
>> 447361eb68a7c9c5b5e0985157c39da1e9924d43 respectively.
>>
>> Do these revisions contain the needed fixes?
>
> From what i can see yes, it seems it does.
>
> Can you please enable it and see if it is good? (Hopefully no regression in
> their or our side was added?).

I've now done so.

>
> Cheers,
>   Albert

Thanks,
Ben

>
>>
>> > Cheers,
>> >
>> >   Albert
>>
>> Regards,
>> Ben
>
>