Web lists-archives.com

Re: Review Request 128189: DocumentUrlDB::del Only assert when children of dir actually exist




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128189/

As there is no bugreport for this one to comment on, an idea how this can happen:

  1. A file is moved to a different directory
  2. The old directory is deleted

The docID is a concatenation of stat.device | stat.inode, thus won't change by moving the file.


- Stefan Brüns


On June 16th, 2016, 5:50 p.m. UTC, Pinak Ahuja wrote:

Review request for Baloo.
By Pinak Ahuja.

Updated June 16, 2016, 5:50 p.m.

Repository: baloo

Description

We can have cases when deleting a directory from DocumentUrlDB when we have some children stored under it which actually don't exist on the file system. This can happen when the dir is being removed from DB because it doesn't exist on the filesystem.

We do need to work on cleaning up the DB when we encounter such behaviour or even better figure out why it is happening and preventing it from happening.

Testing

Fixed crash on CoLa's laptop.

Diffs

  • src/engine/documenturldb.h (9bd5bb5)

View Diff