Web lists-archives.com

Re: Review Request 128189: DocumentUrlDB::del Only assert when children of dir actually exist




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128189/

This change has been marked as submitted.


Review request for Baloo.
By Pinak Ahuja.

Updated June 16, 2016, 5:50 p.m.

Changes

Submitted with commit 1274870e43b879e24c2f76f69544868a021513d3 by Pinak Ahuja to branch master.
Repository: baloo

Description

We can have cases when deleting a directory from DocumentUrlDB when we have some children stored under it which actually don't exist on the file system. This can happen when the dir is being removed from DB because it doesn't exist on the filesystem.

We do need to work on cleaning up the DB when we encounter such behaviour or even better figure out why it is happening and preventing it from happening.

Testing

Fixed crash on CoLa's laptop.

Diffs

  • src/engine/documenturldb.h (9bd5bb5)

View Diff