Web lists-archives.com

Re: Review Request 128183: Ignore malformed Queries which have a binary operator without first argument




This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128183/

This looks very much like something that can be unittested. Is there a unittest framework for this "query parser" ?


src/lib/advancedqueryparser.cpp (Diff revision 1)
156
                qDebug() << "Binary operator withouts first argument encounterd";

withouts -> without encounterd -> encountered

Shouldn't this qDebug() print out "text" ? Otherwise we get a generic debug statement with no context as to why it's shown.


src/lib/advancedqueryparser.cpp (Diff revision 1)
155
            termInConstruction.setProperty(termInConstruction.value().toString());
159
            termInConstruction.setProperty(termInConstruction.value().toString());

use 'property' here, to avoid calling .value().toString() again


- David Faure


On June 14th, 2016, 10:46 a.m. UTC, Pinak Ahuja wrote:

Review request for Baloo and David Faure.
By Pinak Ahuja.

Updated June 14, 2016, 10:46 a.m.

Repository: baloo

Description

Queries like =:2 make our QueryParser behave unexpectedly, now if we have a binary operator without a first arg we just return an empty term.

Diffs

  • src/lib/advancedqueryparser.cpp (a42a3c6)

View Diff