Web lists-archives.com

Re: [PATCH 1/2] Fix URL parsing




Em sábado, 28 de maio de 2016, às 15:37:53 BRT, Arno escreveu:
> Hi Thiago,
> 
> On 5/28/2016 3:01 PM, Thiago Macieira wrote:
> > Em sábado, 28 de maio de 2016, às 01:08:24 BRT, Arno Moeller escreveu:
> >> As it seems, QUrl does not know about rdp://, so url.scheme() is empty.
> >> The old code tried to "fix" it by replacing the scheme with vnc://,
> >> because, as the comment stated, it was default in kde3.
> > 
> > That doesn't make sense. QUrl does know about *any* schemes except "file",
> > which means it recognises them all.
> 
> Hmm, thanks for the hint. krdc calls
> QURL::fromLocalFile("rdp://i.p.a.ddress") which is wrong.
> 
> rpd://<something> is clearly not a local file, but since krdc said it
> it, we end up with file://rdp://i.p.a.ddress, which is garbage...
> 
> I kinda wondered why it worked when setting the URL in the constructor.
> I wonder how this is supposed to work...

Try QUrl::fromUserInput.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center