Web lists-archives.com

Re: Call not guarded properly




Thanks for pointing thus out, I'll have a look

On Jun 2, 2017 07:03, "John Emmas via gtk-devel-list" <gtk-devel-list@xxxxxxxxx> wrote:
After updating glib from git master today I can no longer build with MSVC.  The build now fails to link because gio makes a call to 'g_openuri_portal_open_uri_finish()' (in function 'g_app_info_launch_default_for_uri_finish()')

Looking around at similar calls, I reckon the function should maybe look like this:-

    gboolean
    g_app_info_launch_default_for_uri_finish (GAsyncResult  *result,
                                                                                  GError       **error)
    {
    #ifdef G_OS_UNIX  // <--- This guard added by me !!!!
      return g_openuri_portal_open_uri_finish (result, error);
    #endif
      return FALSE;  // <--- and this added by me !!!!
    }

Should I flag this up in bugzilla or have I misunderstood something?

John

_______________________________________________
gtk-devel-list mailing list
gtk-devel-list@xxxxxxxxx
https://mail.gnome.org/mailman/listinfo/gtk-devel-list


_______________________________________________
gtk-devel-list mailing list
gtk-devel-list@xxxxxxxxx
https://mail.gnome.org/mailman/listinfo/gtk-devel-list