Web lists-archives.com

Re: [PATCH] filechooser: restore pre-3.16 type-ahead-find with setting (off by default)




> On Aug 29, 2015, at 4:50 AM, Thomas Martitz <kugel@xxxxxxxxxxx> wrote:
> 
> The previous type-ahead-find was loved by many people, so removing it without
> possibility to restore was not nice to them. This commit re-introduces it again
> with a default-off seting so that the new default search-as-you-type is
> untouched, for those who don't consider the new search a viable replacement.
> ---
> gtk/gtkfilechooserwidget.c                   | 35 +++++++++++++++++++++++++---
> gtk/org.gtk.Settings.FileChooser.gschema.xml |  7 ++++++
> 2 files changed, 39 insertions(+), 3 deletions(-)
> 
> diff --git a/gtk/gtkfilechooserwidget.c b/gtk/gtkfilechooserwidget.c
> index 94d051f..8d41775 100644
> --- a/gtk/gtkfilechooserwidget.c
> +++ b/gtk/gtkfilechooserwidget.c
> @@ -354,6 +354,7 @@ struct _GtkFileChooserWidgetPrivate {
>   guint show_size_column : 1;
>   guint create_folders : 1;
>   guint auto_selecting_first_row : 1;
> +  guint use_type_ahead_find : 1;

[Snip]


Don’t post patches to the list, they just get lost. Open a bug at https://bugzilla.gnome.org and attach your patch.

To create a patch (or series of patches) commit your changes in your local git repo (ideally in a feature branch) and use `git format-patch` to generate the patches from the commit(s). If that doesn’t instantly make sense there’s an excellent and free git book at http://git-scm.com/documentation.

Regards,
John Ralls


_______________________________________________
gtk-devel-list mailing list
gtk-devel-list@xxxxxxxxx
https://mail.gnome.org/mailman/listinfo/gtk-devel-list