Re: [PATCH 2/3] hash-object doc: elaborate on -w and --literally promises
- Date: Tue, 28 May 2019 09:49:59 -0700
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH 2/3] hash-object doc: elaborate on -w and --literally promises
Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:
> Clarify the hash-object docs to explicitly note that the --literally
> option guarantees that a loose object will be written, but that a
> normal -w ("write") invocation doesn't.
> At first I thought talking about "loose object" in the docs was a
> mistake in 83115ac4a8 ("git-hash-object.txt: document --literally
> option", 2015-05-04), but as is clear from 5ba9a93b39 ("hash-object:
> add --literally option", 2014-09-11) this was intended all along.
I have to admit that this "loose only" was the doing of my
defeatism. IOW, I was utterly pessimistic that I would be able to
add more types (and more importantly, unbounded number of random
types) of objects in the packstream.
So, "loose object" limitation is a practical one for those of us who
cannot think of a reasonable way to cram arbitrary number of random
new types into just 3 bits of the "type" bitfield, and not inherent
to the "hash-object --literally" command.
So I am very happy to see the first hunk of this patch, but I doubt
there is much value in the last sentence the second hunk adds.