Web lists-archives.com

Re: [PATCH 1/2] trace2: rename environment variables to GIT_TRACE2*




SZEDER Gábor <szeder.dev@xxxxxxxxx> writes:

> For an environment variable that is supposed to be set by users, the
> GIT_TR2* env vars are just too unclear, inconsistent, and ugly.

FWIW, I personally am in favor of this change and would prefer to see
this done before the use of the names with unguessable abbreviation
gets ingrained too deeply.  

I do not see any objections around these two patches after waiting
for a week or so, but I do not see any Yay!s, either, so ...

> OTOH, we don't gain anything at all by omitting the last three
> characters of "trace" from the names of these environment variables.
>
> So let's rename all GIT_TR2* environment variables to GIT_TRACE2*,
> before they make their way into a stable release.