Re: [PATCH 00/52] fix some -Wmissing-field-initializer warnings
- Date: Sat, 25 May 2019 00:30:31 +0200
- From: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
- Subject: Re: [PATCH 00/52] fix some -Wmissing-field-initializer warnings
On Fri, May 24 2019, Ramsay Jones wrote:
> [No, I won't be sending 52 patches to the list!]
> This series does not fix any problems or add any new features, so it
> is not important (hence the tendency to 'slip'). I don't want to
> flood the mailing list with patches that nobody wants, so: is there
> any interest in these kinds of patches? If not, I will stop now!
> (I have a 2-3 year old branch that addressed the '-Wsign-compare'
> warnings, but that is probably beyond salvaging by now :( ).
> This series is available from: git://repo.or.cz/git/raj.git with the
> branch name 'warn-master'. A trial merge to current 'next' and 'pu'
> branches can be found at 'warn-next' and 'warn-pu' branches. (The
> merge to 'next' went without problem, and 'pu' only required a fixup
> to the builtin/commit patch).
> What do you think?
I think just send it to the list. We've seen worse, and it's easier to
review than needing to get out of the normal E-Mail workflow.
I'm keen on getting us to stricter compiler warnings in general, but
we'll see whether this specific thing seems worth it in review.