Web lists-archives.com

Re: [PATCH] Use user supplied origin name for extension.partialcone instead of hardcoded value.




Xin Li wrote:

> Subject: Use user supplied origin name for extension.partialcone instead of hardcoded value.

Good catch!

Nits:

- s/partialcone/partialclone/ (missing "l")

- subject lines in git.git tend to be of the form
  "subsystem: lowercase summary" with no trailing period.  So maybe
  something like:

	clone: respect user supplied origin name when setting up partial clone

> Signed-off-by: Xin Li <delphij@xxxxxxxxxx>
> ---
>  builtin/clone.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The change looks obviously good.  With or without a commit message
change like suggested above,

Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>

Thanks.