Web lists-archives.com

Re: [PATCH v3] grep: provide sane default to grep_source struct




On Tue, May 21, 2019 at 05:34:02PM -0700, Emily Shaffer wrote:

> I think Peff and Jonathan are right. If someone does want to hack away
> on something in the very early stages, the BUG() line gives a pretty
> clear indicator of what to modify to make it work.
> 
> I also moved the BUG() to grep_source_1() to keep it close to the error
> itself and reflowed the commit message.

Thanks. This version looks good to me (though if you took any of
Jonathan's suggestions in the other part of the thread that would be
fine with me, too).

-Peff