Web lists-archives.com

Re: [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh






On 5/21/2019 9:07 AM, Randall S. Becker wrote:
On May 21, 2019 07:59, Duy Nguyen wrote:
On Tue, May 21, 2019 at 6:51 PM Ævar Arnfjörð Bjarmason
<avarab@xxxxxxxxx> wrote:
But the real bug looks like the trace2 code unconditionally depending
on pthreads, even though NonStop has 'NO_PTHREADS =
UnfortunatelyYes'
defined.

That's why we get this th%d:unknown stuff, the trace2/tr2_tls.c code
using pthreads is failing with whatever pthread-bizarro NonStop has.

That seems easy enough to "fix", just always fake up "main" if we
don't have pthreads, but perhaps Jeff H. has another opinion on it...

That's not NonStop. thread-utils.h (re)defines pthread_getspecific() to return
NULL when NO_PTHREADS, which triggers this I think.

The platform *is* NonStop, which has SPT and PUT pthreads, but we have never been able to make them work with git, so did not include them in the configuration.


I just reproduced this on my Mac with NO_PTHREADS defined.
I'll post a fix shortly.

Jeff