Re: [PATCH 0/3] Close commit-graph before calling 'gc'
- Date: Mon, 20 May 2019 12:13:23 +0200 (CEST)
- From: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
- Subject: Re: [PATCH 0/3] Close commit-graph before calling 'gc'
On Sun, 19 May 2019, Junio C Hamano wrote:
> "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> > This series adds close_commit_graph() to close_all_packs() and then renames
> > close_all_packs() to close_object_store(). This name is more descriptive of
> > its larger purpose.
> OK. Somebody needs to go though all the existing callers of
> close_all_packs() to see if the above claim is true (unless you
> haven't done so, that is), but I really like the general direction.
I tried to provide that in my review of 3/3.
Please note that these patches are most relevant for Windows, where
renames and deletes fail when any process has an open handle to the
file(s) in question.
P.S.: Now that I think of it, if we close the object store, that's
probably also a time when we want to release the loose object cache.